lkml.org 
[lkml]   [2016]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 36/74] ata: ahci: dont mark HotPlugCapable Ports as external/removable
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Manuel Lauss <manuel.lauss@gmail.com>

    commit dc8b4afc4a04fac8ee55a19b59f2356a25e7e778 upstream.

    The HPCP bit is set by bioses for on-board sata ports either because
    they think sata is hotplug capable in general or to allow Windows
    to display a "device eject" icon on ports which are routed to an
    external connector bracket.

    However in Redhat Bugzilla #1310682, users report that with kernel 4.4,
    where this bit test first appeared, a lot of partitions on sata drives
    are now mounted automatically.

    This patch should fix redhat and a lot of other distros which
    unconditionally automount all devices which have the "removable"
    bit set.

    Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
    Signed-off-by: Tejun Heo <tj@kernel.org>
    Fixes: 8a3e33cf92c7 ("ata: ahci: find eSATA ports and flag them as removable" changes userspace behavior)
    Link: http://lkml.kernel.org/g/56CF35FA.1070500@redhat.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/ata/libahci.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    --- a/drivers/ata/libahci.c
    +++ b/drivers/ata/libahci.c
    @@ -1142,8 +1142,7 @@ static void ahci_port_init(struct device

    /* mark esata ports */
    tmp = readl(port_mmio + PORT_CMD);
    - if ((tmp & PORT_CMD_HPCP) ||
    - ((tmp & PORT_CMD_ESP) && (hpriv->cap & HOST_CAP_SXS)))
    + if ((tmp & PORT_CMD_ESP) && (hpriv->cap & HOST_CAP_SXS))
    ap->pflags |= ATA_PFLAG_EXTERNAL;
    }


    \
     
     \ /
      Last update: 2016-03-08 02:01    [W:7.653 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site