| Date | Fri, 4 Mar 2016 10:50:07 +0000 | From | Juri Lelli <> | Subject | Re: [PATCH v2 9/10] cpufreq: sched: Re-introduce cpufreq_update_util() |
| |
Hi Rafael,
On 04/03/16 04:18, Rafael J. Wysocki wrote:
[...]
> +/** > + * cpufreq_update_util - Take a note about CPU utilization changes. > + * @time: Current time. > + * @util: CPU utilization. > + * @max: CPU capacity. > + * > + * This function is called on every invocation of update_load_avg() on the CPU > + * whose utilization is being updated. > + * > + * It can only be called from RCU-sched read-side critical sections. > + */ > +void cpufreq_update_util(u64 time, unsigned long util, unsigned long max) > +{ > + struct freq_update_hook *hook; > + > +#ifdef CONFIG_LOCKDEP > + WARN_ON(debug_locks && !rcu_read_lock_sched_held()); > +#endif > + > + hook = rcu_dereference(*this_cpu_ptr(&cpufreq_freq_update_hook));
Small fix. You forgot to change this to rcu_dereference_sched() (you only fixed that in 01/10).
Best,
- Juri
|