Messages in this thread | | | Date | Fri, 1 Apr 2016 00:16:02 +0530 | From | "Naveen N. Rao" <> | Subject | Re: [PATCH 1/4] samples/bpf: Fix build breakage with map_perf_test_user.c |
| |
On 2016/03/31 10:43AM, Alexei Starovoitov wrote: > On 3/31/16 4:25 AM, Naveen N. Rao wrote: > >Building BPF samples is failing with the below error: > > > >samples/bpf/map_perf_test_user.c: In function ‘main’: > >samples/bpf/map_perf_test_user.c:134:9: error: variable ‘r’ has > >initializer but incomplete type > > struct rlimit r = {RLIM_INFINITY, RLIM_INFINITY}; > > ^ > >Fix this by including the necessary header file. > > > >Cc: Alexei Starovoitov <ast@fb.com> > >Cc: David S. Miller <davem@davemloft.net> > >Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com> > >Cc: Michael Ellerman <mpe@ellerman.id.au> > >Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> > >--- > > samples/bpf/map_perf_test_user.c | 1 + > > 1 file changed, 1 insertion(+) > > > >diff --git a/samples/bpf/map_perf_test_user.c b/samples/bpf/map_perf_test_user.c > >index 95af56e..3147377 100644 > >--- a/samples/bpf/map_perf_test_user.c > >+++ b/samples/bpf/map_perf_test_user.c > >@@ -17,6 +17,7 @@ > > #include <linux/bpf.h> > > #include <string.h> > > #include <time.h> > >+#include <sys/resource.h> > > #include "libbpf.h" > > #include "bpf_load.h" > > It's failing this way on powerpc? Odd.
This fails for me on x86_64 too -- RHEL 7.1.
> Such hidden header dependency was always puzzling to me. Anyway: > Acked-by: Alexei Starovoitov <ast@kernel.org> > > I'm assuming you want this set to go via 'net' tree, so please resubmit > with [PATCH net 1/4] subjects and cc netdev.
Sure.
> > Reviewing your other patches...
Thanks for your review!
- Naveen
| |