Messages in this thread | | | Date | Thu, 31 Mar 2016 13:17:13 +0300 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH] tpm: cleanup tpm_tis_remove() |
| |
On Thu, Mar 31, 2016 at 01:15:36PM +0300, Jarkko Sakkinen wrote: > Christophe, > > On Thu, Mar 31, 2016 at 01:11:27PM +0300, Jarkko Sakkinen wrote: > > Created a local variable for the register in order to clean up > > experession where TPM_GLOBAL_INT_ENABLE is cleared. This expression is > > horrible to read and makes changing the function uncomfortable because > > like easily surpass 80 characters. > > Can you test this patch your hardware and reply with Tested-by tag if it > does? I can then update your iobase patch to apply on top of this. > > I thought it was better idea to simplify the expression a little bit > than make it even worse mess.
And yes I'll fix all the typos in the commit msg in this patch before applying it :)
/Jarkko
| |