lkml.org 
[lkml]   [2016]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tpm: cleanup tpm_tis_remove()
On Thu, Mar 31, 2016 at 01:15:36PM +0300, Jarkko Sakkinen wrote:
> Christophe,
>
> On Thu, Mar 31, 2016 at 01:11:27PM +0300, Jarkko Sakkinen wrote:
> > Created a local variable for the register in order to clean up
> > experession where TPM_GLOBAL_INT_ENABLE is cleared. This expression is
> > horrible to read and makes changing the function uncomfortable because
> > like easily surpass 80 characters.
>
> Can you test this patch your hardware and reply with Tested-by tag if it
> does? I can then update your iobase patch to apply on top of this.
>
> I thought it was better idea to simplify the expression a little bit
> than make it even worse mess.

And yes I'll fix all the typos in the commit msg in this patch before
applying it :)

/Jarkko

\
 
 \ /
  Last update: 2016-03-31 12:41    [W:0.038 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site