Messages in this thread | | | Date | Fri, 1 Apr 2016 04:30:06 +0100 | From | Al Viro <> | Subject | Re: [PATCH v2] vfs: constify arguments to utime family of system calls |
| |
On Thu, Mar 31, 2016 at 09:24:57PM -0500, Eric Biggers wrote:
> I feel it's a small improvement as it reduces the chance of bugs. However, if > you look at all the system calls, they are, in general, inconsistent about using > 'const'. So may be right that changing just a few isn't worthwhile.
It might very well be worth doing a full series, though - after all, they are not hard to grep for ((COMPAT_)?SYSCALL_DEFINE[0-6] would get you almost all of them, with rest consisting of weird shit in arch/* that more often than not would be better off switched to SYSCALL_DEFINE).
The reason why it's worth doing completely or not at all is that partial series will serve as an invitation to the alt.sex.masturbation.commit.count crowd, with the usual quality of output...
| |