lkml.org 
[lkml]   [2016]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6 2/2] gpio: dwapb: add gpio-signaled acpi event support
From
Date
在 2016/3/30 19:41, Andy Shevchenko 写道:
> On Sat, Mar 26, 2016 at 4:31 AM, qiujiang <qiujiang@huawei.com> wrote:
>> This patch adds gpio-signaled acpi event support. It is used for
>> power button on hisilicon D02 board, an arm64 platform.
>
> Yes, looks good, my tag stays.
>
>> @@ -502,10 +509,17 @@ dwapb_gpio_get_pdata(struct device *dev)
>> }
>> }
>>
>> + if (has_acpi_companion(dev) && pp->idx == 0)
>> + pp->irq = platform_get_irq(to_platform_device(dev), 0);
>> +
>
>> pp->irq_shared = false;
>> pp->gpio_base = -1;
>
>
>> +
>> if (dev->of_node)
>> pp->name = to_of_node(fwnode)->full_name;
>
> This change doesn't belong the patch, though it should gone with the
> two lines of pp->name assignment as per Alan's suggestion to get rid
> of pp->name completely.

Agree, I plan to take Alan's suggestion, thank you.

>
>> +
>> + if (has_acpi_companion(dev))
>> + pp->name = acpi_dev_name(to_acpi_device_node(fwnode));
>

\
 
 \ /
  Last update: 2016-03-31 03:21    [W:0.120 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site