lkml.org 
[lkml]   [2016]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 02/46] backlight: pwm_bl: remove useless call to pwm_set_period()
    Date
    The PWM period will be set when calling pwm_config. Remove this useless
    call to pwm_set_period(), which might mess up with the internal PWM state.

    Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
    Acked-by: Lee Jones <lee.jones@linaro.org>
    ---
    drivers/video/backlight/pwm_bl.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
    index 64f9e1b..a33a290 100644
    --- a/drivers/video/backlight/pwm_bl.c
    +++ b/drivers/video/backlight/pwm_bl.c
    @@ -313,10 +313,8 @@ static int pwm_backlight_probe(struct platform_device *pdev)
    * via the PWM lookup table.
    */
    pb->period = pwm_get_period(pb->pwm);
    - if (!pb->period && (data->pwm_period_ns > 0)) {
    + if (!pb->period && (data->pwm_period_ns > 0))
    pb->period = data->pwm_period_ns;
    - pwm_set_period(pb->pwm, data->pwm_period_ns);
    - }

    pb->lth_brightness = data->lth_brightness * (pb->period / pb->scale);

    --
    2.5.0
    \
     
     \ /
      Last update: 2016-03-30 22:41    [W:7.722 / U:0.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site