lkml.org 
[lkml]   [2016]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] regulator: DT: Add support to scale ramp delay based on platform behavior

    On Saturday 19 March 2016 02:05 PM, Laxman Dewangan wrote:
    >
    > On Saturday 19 March 2016 10:01 AM, Bjorn Andersson wrote:
    >> On Tue, Mar 15, 2016 at 6:41 AM, Laxman Dewangan
    >> <ldewangan@nvidia.com> wrote:
    >>>
    >>>
    >> Generally the device driver should describe the PMIC and the device
    >> tree should describe the board. So the Maxim's numbers should (if
    >> specified at all) go into the driver and the measures/calculated
    >> characteristics for your board should be specified in the dt.
    >>
    >> The ramp properties in the generic regulator binding is used to inform
    >> the OS about the board's ramp properties.
    >>
    >>
    >> If I understand you correctly the Maxim PMIC can be configured to
    >> drive the change at different speed, this should be configured through
    >> a Maxim specific property. It should not reuse the generic properties
    >> for ramp delays.
    >>
    >
    > Ramp delay configurations are seen on other vendor's PMIC devices also.
    > Therefore, I like o me generic property rather than specific to Maxim.
    > Parsing can be done in the core framework and applied during setting
    > machine constraints.

    Any comment on this approach?

    Like to add property as "regulator-device-ramp-delay" which will be used
    for PMIC configuration and regulator-ramp-delay will be used for delay
    calculation. This is case when advertised ramp delay does not match with
    the platform measured ramp delay.

    If regulator-device-ramp-delay is not provided from platform then
    regulator-ramp-delay will be used for PMIC configuration as well as for
    the delay calculation. This is case when advertised ramp delay match
    with the platform measured ramp delay.


    \
     
     \ /
      Last update: 2016-03-30 16:21    [W:3.954 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site