Messages in this thread | | | Date | Wed, 30 Mar 2016 13:01:24 +0100 | From | Lee Jones <> | Subject | Re: [RESEND] phy: Fix build error of missing devm_ioremap_resource on UM |
| |
On Wed, 30 Mar 2016, Krzysztof Kozlowski wrote:
> On 30.03.2016 17:10, Lee Jones wrote: > > On Wed, 30 Mar 2016, Lee Jones wrote: > > > >> On Wed, 30 Mar 2016, Krzysztof Kozlowski wrote: > >> > >>> The devres.o gets linked if HAS_IOMEM is present so on ARCH=um > >>> allyesconfig (COMPILE_TEST) failed with: > >>> > >>> drivers/built-in.o: In function `omap_control_phy_probe': > >>> phy-omap-control.c:(.text+0x16db): undefined reference to `devm_ioremap_resource' > >>> drivers/built-in.o: In function `cygnus_pcie_phy_probe': > >>> phy-bcm-cygnus-pcie.c:(.text+0x1bfa): undefined reference to `devm_ioremap_resource' > >>> > >>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > >>> --- > >>> drivers/phy/Kconfig | 2 ++ > >>> 1 file changed, 2 insertions(+) > >> > >> Holding off on this until the discussion reaches some kind of > >> consensus. > > > > FYI: https://lkml.org/lkml/2016/3/29/716 > > Yeah, I saw it today. > > But this is a little bit different. It is not caused by selecting > MFD_SYSCON but because of unlinked devres.o (which is linked by HAS_IOMEM).
Discussion is continuing. Please follow it until conclusion, then re-submit your patches (remembering to Cc the individuals in the aforementioned conversation).
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |