Messages in this thread | | | Subject | Re: [PATCH 2/7] extcon: usb-gpio: add support for ACPI gpio interface | From | Lu Baolu <> | Date | Thu, 3 Mar 2016 15:35:45 +0800 |
| |
On 03/03/2016 03:24 PM, Chanwoo Choi wrote: > Hi Lu, > > On 2016년 03월 03일 15:37, Lu Baolu wrote: >> GPIO resource could be retrieved through APCI as well. >> >> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com> >> Reviewed-by: Felipe Balbi <balbi@kernel.org> >> --- >> drivers/extcon/extcon-usb-gpio.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c >> index af9c8b0..472c431 100644 >> --- a/drivers/extcon/extcon-usb-gpio.c >> +++ b/drivers/extcon/extcon-usb-gpio.c >> @@ -26,6 +26,7 @@ >> #include <linux/platform_device.h> >> #include <linux/slab.h> >> #include <linux/workqueue.h> >> +#include <linux/acpi.h> >> >> #define USB_GPIO_DEBOUNCE_MS 20 /* ms */ >> >> @@ -91,7 +92,7 @@ static int usb_extcon_probe(struct platform_device *pdev) >> struct usb_extcon_info *info; >> int ret; >> >> - if (!np) >> + if (!np && !ACPI_HANDLE(dev)) >> return -EINVAL; >> >> info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL); >> > Looks good to me. > > Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Thank you!
> > Best Regards, > Chanwoo Choi >
| |