lkml.org 
[lkml]   [2016]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] asix: do not free array priv->mdio->irq
On Thu, Mar 03, 2016 at 01:27:56PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Used to be allocated and required freeing, but now
> priv->mdio->irq is now a fixed sized array and should no longer be
> free'd.
>
> Issue detected using static analysis with CoverityScan
>
> Fixes: e7f4dc3536a400 ("mdio: Move allocation of interrupts into core")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Thanks
Andrew

> ---
> drivers/net/usb/ax88172a.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/usb/ax88172a.c b/drivers/net/usb/ax88172a.c
> index 224e7d8..cf77f2d 100644
> --- a/drivers/net/usb/ax88172a.c
> +++ b/drivers/net/usb/ax88172a.c
> @@ -134,7 +134,6 @@ static void ax88172a_remove_mdio(struct usbnet *dev)
>
> netdev_info(dev->net, "deregistering mdio bus %s\n", priv->mdio->id);
> mdiobus_unregister(priv->mdio);
> - kfree(priv->mdio->irq);
> mdiobus_free(priv->mdio);
> }
>
> --
> 2.7.0
>

\
 
 \ /
  Last update: 2016-03-03 16:01    [W:0.303 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site