Messages in this thread | | | Subject | Re: [PATCH 3/7] usb: misc: add common code for Intel dual role port mux | From | Lu Baolu <> | Date | Fri, 4 Mar 2016 09:25:33 +0800 |
| |
On 03/04/2016 12:15 AM, Greg Kroah-Hartman wrote: > On Thu, Mar 03, 2016 at 02:37:40PM +0800, Lu Baolu wrote: >> +#if IS_ENABLED(CONFIG_USB_MUX) >> +extern int usb_mux_register(struct usb_mux_dev *mux); >> +extern int usb_mux_unregister(struct device *dev); >> +extern struct usb_mux_dev *usb_mux_get_dev(struct device *dev); > This api needs a lot of work, for such a "tiny" api, it's obviously > pretty incorrect. Please fix it up to be sane...
Sure.
> > >
| |