Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH 01/31] bitops: add parity functions | From | "zhaoxiu.zeng" <> | Date | Sun, 27 Mar 2016 15:51:15 +0800 |
| |
On 2016/3/27 6:08, Martin Kepplinger wrote: > We do. > > Am 24. März 2016 23:28:15 MEZ, schrieb Andrew Morton <akpm@linux-foundation.org>: >> On Thu, 24 Mar 2016 09:38:21 +0100 Denys Vlasenko <dvlasenk@redhat.com> >> wrote: >> >>> On 03/24/2016 04:03 AM, Zhaoxiu Zeng wrote: >>>> +/* >>>> + * Type invariant interface to the compile time constant parity >> functions. >>>> + */ >>>> +#define PARITY(w) PARITY64((u64)w) >>> >>> Can result in incorrect expansion of w. Should be PARITY64((u64)(w)) >> >> And we seem to be missing the other 30 patches. >
Sorry,I got some problems with my gmail.
| ![\](/images/icornerr.gif) |