lkml.org 
[lkml]   [2016]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/5] ftrace perf: Move exclude_kernel tracepoint check to init event
On Thu, Mar 24, 2016 at 02:00:45PM +0100, Peter Zijlstra wrote:
> On Thu, Mar 24, 2016 at 01:25:44PM +0100, Jiri Olsa wrote:
> > > > > > $ sudo perf record -e sched:sched_switch:u ls
> > > > > > $ sudo /perf script | wc -l
> > > > > > 0
>
> > > And its not like the [uk] flags are hard to implement here.
> >
> > sched:sched_switch:u ?
>
> As per the above, its implemented and correct. The answer is 0.
>
> The only problem is that currently it assumes all tracepoint events are
> from the kernel, and that is wrong for uprobes.
>
> But returning an error is not right, its a valid configuration, a daft
> one, sure, but not invalid.
>
> Similarly uprobe:foo:k is daft, but broken.

ok, will send fix for uprobes then

thanks,
jirka

\
 
 \ /
  Last update: 2016-03-24 14:41    [W:0.066 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site