Messages in this thread | | | Date | Tue, 22 Mar 2016 17:56:06 +0100 | Subject | Re: [PATCH 2/2] ceph: use kmem_cache_zalloc | From | Ilya Dryomov <> |
| |
On Sun, Mar 13, 2016 at 8:26 AM, Geliang Tang <geliangtang@163.com> wrote: > Use kmem_cache_zalloc() instead of kmem_cache_alloc() with flag GFP_ZERO. > > Signed-off-by: Geliang Tang <geliangtang@163.com> > --- > fs/ceph/dir.c | 2 +- > fs/ceph/file.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/ceph/dir.c b/fs/ceph/dir.c > index fd11fb2..ba01851 100644 > --- a/fs/ceph/dir.c > +++ b/fs/ceph/dir.c > @@ -38,7 +38,7 @@ int ceph_init_dentry(struct dentry *dentry) > if (dentry->d_fsdata) > return 0; > > - di = kmem_cache_alloc(ceph_dentry_cachep, GFP_KERNEL | __GFP_ZERO); > + di = kmem_cache_zalloc(ceph_dentry_cachep, GFP_KERNEL); > if (!di) > return -ENOMEM; /* oh well */ > > diff --git a/fs/ceph/file.c b/fs/ceph/file.c > index eb9028e..bb4950a 100644 > --- a/fs/ceph/file.c > +++ b/fs/ceph/file.c > @@ -157,7 +157,7 @@ static int ceph_init_file(struct inode *inode, struct file *file, int fmode) > case S_IFDIR: > dout("init_file %p %p 0%o (regular)\n", inode, file, > inode->i_mode); > - cf = kmem_cache_alloc(ceph_file_cachep, GFP_KERNEL | __GFP_ZERO); > + cf = kmem_cache_zalloc(ceph_file_cachep, GFP_KERNEL); > if (cf == NULL) { > ceph_put_fmode(ceph_inode(inode), fmode); /* clean up */ > return -ENOMEM;
Applied.
Thanks,
Ilya
| |