Messages in this thread | | | Date | Tue, 22 Mar 2016 10:59:41 +0100 | From | David Sterba <> | Subject | Re: [PATCH] btrfs: fix build warning |
| |
On Tue, Mar 22, 2016 at 10:39:59AM +0100, Geert Uytterhoeven wrote: > On Tue, Feb 16, 2016 at 9:02 AM, Sudip Mukherjee > <sudipm.mukherjee@gmail.com> wrote: > > We were getting build warning about: > > fs/btrfs/extent-tree.c:7021:34: warning: ‘used_bg’ may be used > > uninitialized in this function > > > > It is not a valid warning as used_bg is never used uninitilized since > > locked is initially false so we can never be in the section where > > 'used_bg' is used. But gcc is not able to understand that and we can > > initialize it while declaring to silence the warning. > > > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > > FWIW, I've posted an alternative patch that killed the silly locked variable > a while ago. > "[PATCH] Btrfs: Refactor btrfs_lock_cluster() to kill compiler warning" > https://lkml.org/lkml/2014/6/22/96
The cleanup looks great, thanks, patch picked.
| |