lkml.org 
[lkml]   [2016]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net 03/10] net: hns: add uc match for debug ports
From
Date


在 2016/3/21 23:40, David Miller 写道:
> From: Yisen Zhuang <Yisen.Zhuang@huawei.com>
> Date: Mon, 21 Mar 2016 19:06:34 +0800
>
>> + (void)hns_mac_set_promisc(mac_cb, (u8)!!en);
>
> This cast to void is unnecssary.

I think hns_mac_set_promisc don't need to return a value, so i will fix it in next submit.

Thanks

>
>> +static void hns_gmac_set_uc_match(void *mac_drv, u16 en)
>> +{
>> + struct mac_driver *drv = (struct mac_driver *)mac_drv;
>
> Casts from void pointers are unnecessary.

Will fix it in next submit.

Thanks

>
>> +{
>> + struct mac_driver *drv = (struct mac_driver *)mac_drv;
>
> Likewise.

Will fix it in next submit.

Thanks,

Yisen

>
> .
>

\
 
 \ /
  Last update: 2016-03-22 02:41    [W:0.070 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site