Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 21 Mar 2016 23:05:28 +0100 | From | Andi Kleen <> | Subject | Re: [PATCH 2/9] x86: Add support for rd/wr fs/gs base |
| |
> Please add a patch before this one that renames gs to gsbase. This is > unreadable as is.
I investigated this now, and it's not straight forward because on 32bit ->gs is actually gsindex, not gsbase. So with a straight rename you would end up with index in base on 32bit, which would be confusing.
Perhaps this could be cleaned up at some point, switching 32bit to use ->gsindex. But not right now, seems somewhat risky, and I don't want to make it part of this patch kit.
FWIW I think it's readable.
-Andi
-- ak@linux.intel.com -- Speaking for myself only.
| ![\](/images/icornerr.gif) |