lkml.org 
[lkml]   [2016]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Updated version of RD/WR FS/GS BASE patchkit
    > You're adding an hwcap bit because you expect user code to use this
    > thing, which means you're adding an ABI, which means that the
    > semantics should be given due consideration.

    Right I did that and concluded the existing semantics are fine.
    They also worked fine for many years with the system call.

    We have two different modi:

    - Code uses old FS/GS selector, gs selector is not zero
    In this case the selector base in GDT/LDT takes preference.

    This is legacy, but still works fine.

    - Code uses 64bit base, either through arch_prctl or the new
    instructions. In this case FS/GS selector has to be zero.

    This is the new expected mode for 64bit code.

    With the new instructions the modi can be temporarily
    out of sync (GS/FS != 0, but a different base loaded),
    but will always be reset on the next context switch.

    Your previous objection was that this allows to detect
    context switches, but that's already possible in other
    ways so I think it's a red hering.

    Also if you really want to change it you can do so
    in a followon patch under your own name.

    -Andi
    --
    ak@linux.intel.com -- Speaking for myself only.

    \
     
     \ /
      Last update: 2016-03-21 21:21    [W:5.259 / U:1.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site