Messages in this thread | | | Date | Mon, 21 Mar 2016 11:54:19 +0000 | From | Lee Jones <> | Subject | Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: remove clock tree on error path |
| |
On Fri, 26 Feb 2016, Stephen Boyd wrote:
> On 02/19, Andy Shevchenko wrote: > > There is a potential resource leak in case when ->probe() fails. We have to > > unregister and remove clock tree which is done here. > > > > This is a follow up to previously pushed commit c4726abce63b ("mfd: > > intel_quark_i2c_gpio: Use clkdev_create()") that prevents double free() when > > clkdev_drop() followed by kfree() in devm_kcalloc() release stage. > > > > I leave Fixes tag here, but the backporting will require to backport the commit > > c4726abce63b ("mfd: intel_quark_i2c_gpio: Use clkdev_create()") first. > > > > Fixes: 60ae5b9f5cdd (mfd: intel_quark_i2c_gpio: Add Intel Quark X1000 I2C-GPIO MFD Driver) > > Cc: stable@vger.kernel.org > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > --- > > Both look fine to me. You may also want to use > devm_clk_register() instead so that cleanup is easier.
I'm going to apply your Ack in order to show that you've seen and have no problems with the patch.
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |