Messages in this thread | | | Date | Mon, 21 Mar 2016 10:10:54 +0100 | From | Boris Brezillon <> | Subject | Re: [patch] crypto: marvell/cesa - remove unneeded condition |
| |
On Mon, 21 Mar 2016 12:03:43 +0300 Dan Carpenter <dan.carpenter@oracle.com> wrote:
> creq->cache[] is an array inside the struct, it's not a pointer and it > can't be NULL. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> > diff --git a/drivers/crypto/marvell/hash.c b/drivers/crypto/marvell/hash.c > index 7ca2e0f..7a5058d 100644 > --- a/drivers/crypto/marvell/hash.c > +++ b/drivers/crypto/marvell/hash.c > @@ -768,8 +768,7 @@ static int mv_cesa_ahash_export(struct ahash_request *req, void *hash, > *len = creq->len; > memcpy(hash, creq->state, digsize); > memset(cache, 0, blocksize); > - if (creq->cache) > - memcpy(cache, creq->cache, creq->cache_ptr); > + memcpy(cache, creq->cache, creq->cache_ptr); > > return 0; > }
-- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
| |