Messages in this thread | | | Subject | Re: [PATCHv7 5/7] eeprom: at25: extend driver to plug into the NVMEM framework | From | Vladimir Zapolskiy <> | Date | Wed, 2 Mar 2016 23:56:16 +0200 |
| |
Hi Andrew,
On 26.02.2016 21:59, Andrew Lunn wrote: > Add a regmap for accessing the EEPROM, and then use that with the > NVMEM framework. Enable backwards compatibility in the NVMEM config, > so that the 'eeprom' file in sys is provided by the framework. > > Signed-off-by: Andrew Lunn <andrew@lunn.ch> > Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > ---
[snip]
> > -static ssize_t > -at25_bin_read(struct file *filp, struct kobject *kobj, > - struct bin_attribute *bin_attr, > - char *buf, loff_t off, size_t count) > +static int at25_regmap_read(void *context, const void *reg, size_t reg_size, > + void *val, size_t val_size) > { > - struct device *dev; > - struct at25_data *at25; > - > - dev = kobj_to_dev(kobj); > - at25 = dev_get_drvdata(dev); > + struct at25_data *at25 = context; > + off_t offset = *(u32 *)reg; > + int err; > > - return at25_ee_read(at25, buf, off, count); > + err = at25_ee_read(at25, val, offset, val_size); > + if (err) > + return err; > + return 0;
return at25_ee_read(at25, val, offset, val_size);
> } >
[snip]
> > -static ssize_t > -at25_bin_write(struct file *filp, struct kobject *kobj, > - struct bin_attribute *bin_attr, > - char *buf, loff_t off, size_t count) > +static int at25_regmap_write(void *context, const void *data, size_t count) > { > - struct device *dev; > - struct at25_data *at25; > + struct at25_data *at25 = context; > + const char *buf; > + u32 offset; > + size_t len; > + int err; > > - dev = kobj_to_dev(kobj); > - at25 = dev_get_drvdata(dev); > + memcpy(&offset, data, sizeof(offset)); > + buf = (const char *)data + sizeof(offset); > + len = count - sizeof(offset); > > - return at25_ee_write(at25, buf, off, count); > + err = at25_ee_write(at25, buf, offset, len); > + if (err) > + return err; > + return 0;
return at25_ee_write(at25, buf, offset, len) is shorter.
> }
-- With best wishes, Vladimir
| |