lkml.org 
[lkml]   [2016]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH mmotm] mm, sl[au]b: print gfp_flags as strings in slab_out_of_memory()
From
Date
On 03/01/2016 11:41 PM, David Rientjes wrote:
> On Tue, 1 Mar 2016, Vlastimil Babka wrote:
>
>> We can now print gfp_flags more human-readable. Make use of this in
>> slab_out_of_memory() for SLUB and SLAB. Also convert the SLAB variant it to
>> pr_warn() along the way.
>>
>> Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
>> Cc: Christoph Lameter <cl@linux.com>
>> Cc: Pekka Enberg <penberg@kernel.org>
>> Cc: David Rientjes <rientjes@google.com>
>> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
>
> Acked-by: David Rientjes <rientjes@google.com>

Thanks.

> Although I've always been curious about the usefulness of these out of
> memory calls in the first place. They are obviously for debugging, but
> have they actually helped to diagnose anything?

Uh no idea, maybe other SL*B maintainers have more experience. But what
did prompt me to write this patch is that I've recently have actually
seen the output of those in some (presumably linux-mm) thread.

\
 
 \ /
  Last update: 2016-03-02 16:01    [W:0.069 / U:2.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site