lkml.org 
[lkml]   [2016]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH V2 1/2] x86/perf/intel/uncore: Make Intel uncore modular
Date

>
> On Fri, 18 Mar 2016, kan.liang@intel.com wrote:
>
> > From: Kan Liang <kan.liang@intel.com>
> >
> > This patch makes Intel uncore pmu driver modular.
> > By default, the uncore driver will be built in the kernel. If it is
> > configured as module, the supported cpu model can be auto loaded.
> > This patch also cleans up the code of cpu_init and pci_init.
>
> Nice work!
>
> > +static struct intel_uncore_init_fun skl_uncore_init = {
> > + .pci_init = skl_uncore_pci_init,
> > +};
> > +
> > +static const struct x86_cpu_id intel_uncore_match[] = {
>
> Shouldn't all of these structs be const __initconst?
>

Thanks for the review. I will fix it in next version.

Thanks,
Kan

> Other than that:
>
> Reviewed-by: Thomas Gleixner <tglx@linutronix.de>

\
 
 \ /
  Last update: 2016-03-18 20:21    [W:0.133 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site