Messages in this thread | | | Subject | Re: [PATCH 1/2] watchdog: Fix output | From | Joe Perches <> | Date | Fri, 18 Mar 2016 10:42:02 -0700 |
| |
On Fri, 2016-03-18 at 17:48 +0100, Peter Zijlstra wrote: > On Fri, Mar 18, 2016 at 05:44:41PM +0100, Peter Zijlstra wrote: > > > > On Fri, Mar 18, 2016 at 12:37:48PM -0400, Don Zickus wrote: > > > > > > Would something like this be a better patch? > > > > > > -#define pr_fmt(fmt) "NMI watchdog: " fmt > > > +#define pr_fmt(fmt) "Lockup detector: " fmt > You might want to audit all the other pr_ nonsense in that file; a > lot > of the msgs don't particularly make sense when combined with the > prefix. > > Some are for the NMI thing, others for the soft lockup one. > > I would just chuck pr_crap() altogether and use sensible text.
or change to #define pr_fmt(fmt) fmt
and output whatever unprefixed content you want.
btw: the first printk/pr_emerg should add a newline
pr_emerg("Watchdog detected hard LOCKUP on cpu %d", this_cpu); sb: pr_emerg("Watchdog detected hard LOCKUP on cpu %d\n", this_cpu);
| |