Messages in this thread | | | Subject | Re: Suspicious error for CMA stress test | From | Vlastimil Babka <> | Date | Fri, 18 Mar 2016 13:29:26 +0100 |
| |
On 03/17/2016 07:54 AM, Joonsoo Kim wrote: > On Wed, Mar 16, 2016 at 05:44:28PM +0800, Hanjun Guo wrote: >> On 2016/3/14 15:18, Joonsoo Kim wrote: >> >> Hmm, this one is not work, I still can see the bug is there after applying >> this patch, did I miss something? > > I may find that there is a bug which was introduced by me some time > ago. Could you test following change in __free_one_page() on top of > Vlastimil's patch? > > -page_idx = pfn & ((1 << max_order) - 1); > +page_idx = pfn & ((1 << MAX_ORDER) - 1);
I think it wasn't a bug in the context of 3c605096d31, but it certainly Does become a bug with my patch, so thanks for catching that.
Actually I've earlier concluded that this line is not needed at all, and can lead to smaller code, and enable even more savings. But I'll leave that after the fix that needs to go to stable.
> Thanks. > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> >
| |