Messages in this thread | | | Subject | Re: [PATCH 5/8] sched/cpufreq: pass sched class into cpufreq_update_util | From | Steve Muckle <> | Date | Tue, 15 Mar 2016 20:55:35 -0700 |
| |
Hi Mike,
On 03/15/2016 03:06 PM, Michael Turquette wrote: >>> > > void cpufreq_set_freq_update_hook(int cpu, struct freq_update_hook *hook, >>> > > + void (*func)(struct freq_update_hook *hook, >>> > > + enum sched_class_util sched_class, >>> > > + u64 time, unsigned long util, >>> > > + unsigned long max)); >> > >> > Have you looked at the asm that generated? At some point you'll start >> > spilling on the stack and it'll be a god awful mess. >> > > Is your complaint about the enum that I added to the existing function > signature, or do you not like the original function signature[0] from > Rafael's patch, sans enum?
The ARM procedure call standard has the first four arguments in registers so the addition of the enum above will start using the stack.
| |