lkml.org 
[lkml]   [2016]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch] block-dev: checking for NULL instead of IS_ERR()
    On Tue, Mar 08, 2016 at 03:05:46PM +0300, Dan Carpenter wrote:
    > This should be an IS_ERR() check. mount_pseudo() returns error pointers
    > and this function should return the error pointer to its caller as well.
    >
    > Fixes: 3684aa7099e0 ('block-dev: enable writeback cgroup support')
    > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

    Looks fine. Would be much nicer to simply pass possible flags as an
    argument to mount_pseudo to avoid this whole dance..

    Reviewed-by: Christoph Hellwig <hch@lst.de>

    \
     
     \ /
      Last update: 2016-03-15 09:01    [W:4.246 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site