lkml.org 
[lkml]   [2016]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 4/5] gpio: DT: Rephrase "gpios" of hog node to support multiple gpios

On Monday 14 March 2016 10:01 PM, Stephen Warren wrote:
> On 03/11/2016 06:43 AM, Laxman Dewangan wrote:
>> The property "gpios" of GPIO hog node support the multiple GPIO entries.
>> Rephrase the details of this property for this new support.
>>
>> Add details of new property "label" for GPIO label name.
>
>> diff --git a/Documentation/devicetree/bindings/gpio/gpio.txt
>> b/Documentation/devicetree/bindings/gpio/gpio.txt
>
>> Optional properties:
>> - line-name: The GPIO label name. If not present the node name is
>> used.
>> +- label: The GPIO lable name. This can have multiple string for
>> GPIO
>> + label names to match with the GPIOs in "gpios" properties.
>> + If line-name is prosent than name is taken from line-name. If
>> + it is not then the name will be taken from label. If both are
>> + not available then node name is used for GPIO label name.
>
> Why are there two properties for the same thing? Why not just allow
> line-name to have multiple entries instead of introducing a new property?
>

We can use the lin-names also but per disucssion on the patch V1 of
gpio: of: Add support to have multiple gpios in gpio-hog

Markus suggested the discussion about the discussion
(https://lkml.org/lkml/2016/3/10/194):
"Device tree binding documentation for gpio-switch"


and on that, label is used. Also for names, "label" is going to very
common.

So I added new property "label" to support multiple names.

\
 
 \ /
  Last update: 2016-03-15 08:21    [W:0.056 / U:0.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site