Messages in this thread | | | Subject | Re: [PATCH] iommu/vt-d: Ratelimit fault handler | From | David Woodhouse <> | Date | Tue, 15 Mar 2016 19:47:56 +0000 |
| |
On Tue, 2016-03-15 at 10:35 -0600, Alex Williamson wrote: > Fault rates can easily overwhelm the console and make the system > unresponsive. Ratelimit to allow an opportunity for maintenance. > > Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Rather than just rate-limiting the printk, I'd prefer to handle this explicitly. There's a bit in the context-entry which can tell the IOMMU not to bother raising an interrupt at all. And then we can re-enable it if/when the driver recovers the device. (Or perhaps just when it next does a mapping).
We really ought to be reporting faults to drivers too, FWIW. I keep meaning to take a look at that.
-- David Woodhouse Open Source Technology Centre David.Woodhouse@intel.com Intel Corporation
[unhandled content-type:application/x-pkcs7-signature] | |