lkml.org 
[lkml]   [2016]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Fix suspicious RCU usage in msr tracing.
> Back in January, Andi suggested swapping the order in which
> we ack the APIC irq, so it too is protected by rcu.
> There was no follow-up, and it seems to work for me.
>
> Cc: Andi Kleen <ak@linux.intel.com>

Reviewed-by: Andi Kleen <ak@linux.intel.com>

-Andi

> Signed-off-by: Dave Jones <davej@codemonkey.org.uk>
>
> diff --git a/arch/x86/include/asm/apic.h b/arch/x86/include/asm/apic.h
> index c80f6b6f3da2..e8c4fba52d3d 100644
> --- a/arch/x86/include/asm/apic.h
> +++ b/arch/x86/include/asm/apic.h
> @@ -644,8 +644,8 @@ static inline void entering_irq(void)
>
> static inline void entering_ack_irq(void)
> {
> - ack_APIC_irq();
> entering_irq();
> + ack_APIC_irq();
> }
>
> static inline void ipi_entering_ack_irq(void)

--
ak@linux.intel.com -- Speaking for myself only

\
 
 \ /
  Last update: 2016-03-15 18:21    [W:0.064 / U:0.764 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site