Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH] usb: gadget: f_midi: Fixed a bug when buflen was smaller than wMaxPacketSize | From | Clemens Ladisch <> | Date | Tue, 15 Mar 2016 10:48:34 +0100 |
| |
Felipe Ferreri Tonello wrote: > On 11/03/16 23:07, Michal Nazarewicz wrote: >> I’m also wondering whether it would be beneficial to get rid of buflen >> all together and use wMaxPacketSie for in endpoints as well? Is that >> feasible? > > Yes, we could just remove the buflen parameter. > > The only scenario where I can see buflen been "useful" is if the user > wants to have a smaller buffer size for the OUT endpoint. Should we > support this case or not?
Splitting data into multiple packets would not make sense from a performance perspective. The only possible reason would be to work around a (theoretical) bug in some host software that does not handle larger buffers, but there aren't that many host implementations, and I am not aware of any with such a bug.
Regards, Clemens
| ![\](/images/icornerr.gif) |