lkml.org 
[lkml]   [2016]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/22] ncr5380: Adopt uniform DMA setup convention

On Mon, 14 Mar 2016, Hannes Reinecke wrote:

> > @@ -1555,8 +1555,7 @@ static int NCR5380_transfer_dma(struct S
> > NCR5380_read(RESET_PARITY_INTERRUPT_REG);
> > *data = d + c;
> > *count = 0;
> > - *phase = NCR5380_read(STATUS_REG) & PHASE_MASK;
> > - return foo;
> > + return result;
> > }
> >
> > /*
>
> Don't you miss a phase update here?

I guess I missed explaining the change in the commit log.

The *phase assignment is redundant because after NCR5380_transfer_dma()
returns control to NCR5380_information_transfer(), the latter routine then
also returns, and so *phase is dead.

--

>
> Cheers,
>
> Hannes
>

\
 
 \ /
  Last update: 2016-03-15 05:01    [W:0.115 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site