Messages in this thread | | | Date | Tue, 15 Mar 2016 14:19:58 +1100 (AEDT) | From | Finn Thain <> | Subject | Re: [PATCH 09/22] ncr5380: Adopt uniform DMA setup convention |
| |
On Mon, 14 Mar 2016, Hannes Reinecke wrote:
> > @@ -1555,8 +1555,7 @@ static int NCR5380_transfer_dma(struct S > > NCR5380_read(RESET_PARITY_INTERRUPT_REG); > > *data = d + c; > > *count = 0; > > - *phase = NCR5380_read(STATUS_REG) & PHASE_MASK; > > - return foo; > > + return result; > > } > > > > /* > > Don't you miss a phase update here?
I guess I missed explaining the change in the commit log.
The *phase assignment is redundant because after NCR5380_transfer_dma() returns control to NCR5380_information_transfer(), the latter routine then also returns, and so *phase is dead.
--
> > Cheers, > > Hannes >
| |