lkml.org 
[lkml]   [2016]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 5/5] Staging: comedi: Fix type issue in ni_tio.c
From
Date
On Mon, 2016-03-14 at 16:36 +0530, Ravishankar Karkala Mallikarjunayya wrote:
> This is a patch to the ni_tio.c file that fixes up a type issues
> found by the checkpatch.pl tool.
> i.e. Prefer kernel type 'u64' over 'uint64_t'
[]
> diff --git a/drivers/staging/comedi/drivers/ni_tio.c b/drivers/staging/comedi/drivers/ni_tio.c
[]
> @@ -189,7 +189,7 @@ static void ni_tio_reset_count_and_disarm(struct ni_gpct *counter)
>  static uint64_t ni_tio_clock_period_ps(const struct ni_gpct *counter,
>          unsigned generic_clock_source)
>  {
> - uint64_t clock_period_ps;
> + u64 clock_period_ps;

Please don't blinkeredly fix checkpatch messages.
Understand the code, not just the checkpatch output.

This function returns a uint64_t, maybe it should be
converted to u64 as well.


\
 
 \ /
  Last update: 2016-03-14 16:21    [W:0.634 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site