lkml.org 
[lkml]   [2016]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] [v3] x86, pkeys: fix siginfo ABI breakage from new field

* Ingo Molnar <mingo@kernel.org> wrote:

> > I also shouldn't have been using a u64 in a userspace API to begin with.
>
> Well, it's __u64 that we use in UAPIs, and they can be used just fine, as long
> as the structure's field alignments is managed explicitly, i.e. there's no
> automatic alignment padding done by the compiler.

Btw., what we should not have used in a modern user ABI are variable size
pointers:

struct {
void __user *_lower;
void __user *_upper;
} _addr_bnd;

we should have used constant size structure elements for that, such as __u64.

Had we done that, the pkeys change would not have been a problem either.

Is it too late to change that, is there any si_code=SEGV_BNDERR usage in
user-space?

Thanks,

Ingo

\
 
 \ /
  Last update: 2016-03-01 09:41    [W:0.278 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site