lkml.org 
[lkml]   [2016]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 342/342] iwlwifi: mvm: dont allow sched scans without matches to be started
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Luca Coelho <luciano.coelho@intel.com>

    commit 5e56276e7555b34550d51459a801ff75eca8b907 upstream.

    The firmware can perform a scheduled scan with not matchsets passed,
    but it can't send notification that results were found. Since the
    userspace then cannot know when we got new results and the firmware
    wouldn't trigger a wake in case we are sleeping, it's better not to
    allow scans without matchsets.

    This fixes https://bugzilla.kernel.org/show_bug.cgi?id=110831

    Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
    Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/wireless/iwlwifi/mvm/scan.c | 4 ++++
    1 file changed, 4 insertions(+)

    --- a/drivers/net/wireless/iwlwifi/mvm/scan.c
    +++ b/drivers/net/wireless/iwlwifi/mvm/scan.c
    @@ -1267,6 +1267,10 @@ int iwl_mvm_sched_scan_start(struct iwl_
    return -EBUSY;
    }

    + /* we don't support "match all" in the firmware */
    + if (!req->n_match_sets)
    + return -EOPNOTSUPP;
    +
    ret = iwl_mvm_check_running_scans(mvm, type);
    if (ret)
    return ret;
    \
     
     \ /
      Last update: 2016-03-02 01:41    [W:4.146 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site