Messages in this thread | | | Date | Tue, 1 Mar 2016 22:38:35 +0200 | Subject | Re: [RFC PATCH 8/9] i2c: i2c-mux: Allow for NULL select callback | From | Daniel Baluta <> |
| |
On Tue, Mar 1, 2016 at 10:30 PM, Wolfram Sang <wsa@the-dreams.de> wrote: > On Thu, Feb 18, 2016 at 05:53:13PM +0200, Daniel Baluta wrote: >> From: Adriana Reus <adriana.reus@intel.com> >> >> Add a check in i2c_mux_master_xfer before calling the select callback. >> This is necessary so that NULL callbacks can be safely registered. >> >> Signed-off-by: Adriana Reus <adriana.reus@intel.com> >> Signed-off-by: Daniel Baluta <daniel.baluta@intel.com> > > Hmm, rather than supporting that in the core, I'd prefer to have the > driver pass an empty function instead. Then, in the driver, we can have > a comment explaining the special situation.
Agree. This seems a better idea forcing the user to explain the situation :).
| |