Messages in this thread | | | Subject | Re: [PATCH v2 1/3] ACPI/NFIT: Update Control Region Structure to comply ACPI 6.1 | From | Toshi Kani <> | Date | Tue, 01 Mar 2016 12:53:12 -0700 |
| |
On Tue, 2016-03-01 at 10:14 -0800, Dan Williams wrote: > On Tue, Mar 1, 2016 at 9:36 AM, Toshi Kani <toshi.kani@hpe.com> wrote: > > On Tue, 2016-03-01 at 16:03 +0000, Moore, Robert wrote: : > I think the "ACPI tables are little-endian" assumption is pervasive > throughout the implementation. > > Toshi, it seems all we need is conversions like: > > - sprintf(buf, "%#x\n", dcr->vendor_id); > + sprintf(buf, "%#x\n", le16_to_cpu(dcr->vendor_id));
nit - I think it needs to be be16_to_cpu() if I understand this macro correctly. -Toshi
> > ...for the values exported to userspace through sysfs, but otherwise > leave the base table definitions as is. Will this suffice?
| |