lkml.org 
[lkml]   [2016]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/3] ACPI/NFIT: Update Control Region Structure to comply ACPI 6.1
From
Date
On Tue, 2016-03-01 at 10:14 -0800, Dan Williams wrote:
> On Tue, Mar 1, 2016 at 9:36 AM, Toshi Kani <toshi.kani@hpe.com> wrote:
> > On Tue, 2016-03-01 at 16:03 +0000, Moore, Robert wrote:
 :
> I think the "ACPI tables are little-endian" assumption is pervasive
> throughout the implementation.
>
> Toshi, it seems all we need is conversions like:
>
> - sprintf(buf, "%#x\n", dcr->vendor_id);
> + sprintf(buf, "%#x\n", le16_to_cpu(dcr->vendor_id));

nit - I think it needs to be be16_to_cpu() if I understand this macro
correctly.
-Toshi

>
> ...for the values exported to userspace through sysfs, but otherwise
> leave the base table definitions as is.  Will this suffice?

\
 
 \ /
  Last update: 2016-03-01 21:21    [W:0.113 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site