Messages in this thread | | | Date | Wed, 2 Mar 2016 10:44:21 +0900 | From | Mark Brown <> | Subject | Re: [PATCH 2/4] regulator: core: Add support for active-discharge configuration |
| |
On Tue, Mar 01, 2016 at 06:08:13PM +0530, Laxman Dewangan wrote:
> + * @active_discharge: Enable/disable active discharge. The values are: > + * -1: Default, 0: Disable, 1: Enable.
This isn't a good interface, it means that 0 (which is the default value for static constrants or kzalloc()ed constraints) means to actively discharge rather than leave the settings unchanged but our general policy is to not touch anything unless explicitly told to do so. [unhandled content-type:application/pgp-signature] | |