lkml.org 
[lkml]   [2016]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.14 110/130] drm/qxl: use kmalloc_array to alloc reloc_info in qxl_process_single_command
    Date
    3.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Gerd Hoffmann <kraxel@redhat.com>

    commit 34855706c30d52b0a744da44348b5d1cc39fbe51 upstream.

    This avoids integer overflows on 32bit machines when calculating
    reloc_info size, as reported by Alan Cox.

    Cc: gnomes@lxorguk.ukuu.org.uk
    Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
    Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
    Signed-off-by: Dave Airlie <airlied@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/gpu/drm/qxl/qxl_ioctl.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/gpu/drm/qxl/qxl_ioctl.c
    +++ b/drivers/gpu/drm/qxl/qxl_ioctl.c
    @@ -168,7 +168,8 @@ static int qxl_process_single_command(st
    cmd->command_size))
    return -EFAULT;

    - reloc_info = kmalloc(sizeof(struct qxl_reloc_info) * cmd->relocs_num, GFP_KERNEL);
    + reloc_info = kmalloc_array(cmd->relocs_num,
    + sizeof(struct qxl_reloc_info), GFP_KERNEL);
    if (!reloc_info)
    return -ENOMEM;
    \
     
     \ /
      Last update: 2016-03-02 03:21    [W:4.123 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site