lkml.org 
[lkml]   [2016]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 066/342] bcache: unregister reboot notifier if bcache fails to unregister device
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Zheng Liu <wenqing.lz@taobao.com>

    commit 2ecf0cdb2b437402110ab57546e02abfa68a716b upstream.

    In bcache_init() function it forgot to unregister reboot notifier if
    bcache fails to unregister a block device. This commit fixes this.

    Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
    Tested-by: Joshua Schmid <jschmid@suse.com>
    Tested-by: Eric Wheeler <bcache@linux.ewheeler.net>
    Cc: Kent Overstreet <kmo@daterainc.com>
    Signed-off-by: Jens Axboe <axboe@fb.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/md/bcache/super.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/md/bcache/super.c
    +++ b/drivers/md/bcache/super.c
    @@ -2071,8 +2071,10 @@ static int __init bcache_init(void)
    closure_debug_init();

    bcache_major = register_blkdev(0, "bcache");
    - if (bcache_major < 0)
    + if (bcache_major < 0) {
    + unregister_reboot_notifier(&reboot);
    return bcache_major;
    + }

    if (!(bcache_wq = create_workqueue("bcache")) ||
    !(bcache_kobj = kobject_create_and_add("bcache", fs_kobj)) ||
    \
     
     \ /
      Last update: 2016-03-02 02:41    [W:4.035 / U:0.316 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site