lkml.org 
[lkml]   [2016]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 125/342] coresight: checking for NULL string in coresight_name_match()
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Mathieu Poirier <mathieu.poirier@linaro.org>

    commit fadf3a44e974b030e7145218ad1ab25e3ef91738 upstream.

    Connection child names associated to ports can sometimes be NULL,
    which is the case when booting a system on QEMU or when the Coresight
    power domain isn't switched on.

    This patch is adding a check to make sure a NULL string isn't fed
    to strcmp(), something that avoid crashing the system.

    Reported-by: Tyler Baker <tyler.baker@linaro.org>
    Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/hwtracing/coresight/coresight.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/hwtracing/coresight/coresight.c
    +++ b/drivers/hwtracing/coresight/coresight.c
    @@ -548,7 +548,7 @@ static int coresight_name_match(struct d
    to_match = data;
    i_csdev = to_coresight_device(dev);

    - if (!strcmp(to_match, dev_name(&i_csdev->dev)))
    + if (to_match && !strcmp(to_match, dev_name(&i_csdev->dev)))
    return 1;

    return 0;
    \
     
     \ /
      Last update: 2016-03-02 02:41    [W:3.911 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site