lkml.org 
[lkml]   [2016]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 141/342] mmc: pxamci: fix again read-only gpio detection polarity
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Robert Jarzmik <robert.jarzmik@free.fr>

    commit 41c89159a6ae5472d39ed8bded5b3b4e07a37944 upstream.

    The commit fixing the conversion of pxamci to slot-gpio API fixed the
    inverted the logic of the read-only gpio. Unfortunately, the commit was
    tested on a non-inverted gpio, and not on the inverted one. And the fix
    did work partially, by luck.

    This is the remaining missing part of the fix, trivial but still necessary.

    Fixes: Fixes: 26d49fe71953 ("mmc: pxamci: fix read-only gpio detection polarity")
    Reported-by: Andrea Adami <andrea.adami@gmail.com>
    Tested-by: Andrea Adami <andrea.adami@gmail.com>
    Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/mmc/host/pxamci.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/mmc/host/pxamci.c
    +++ b/drivers/mmc/host/pxamci.c
    @@ -804,7 +804,7 @@ static int pxamci_probe(struct platform_
    dev_err(&pdev->dev, "Failed requesting gpio_ro %d\n", gpio_ro);
    goto out;
    } else {
    - mmc->caps |= host->pdata->gpio_card_ro_invert ?
    + mmc->caps2 |= host->pdata->gpio_card_ro_invert ?
    0 : MMC_CAP2_RO_ACTIVE_HIGH;
    }
    \
     
     \ /
      Last update: 2016-03-02 02:21    [W:4.090 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site