lkml.org 
[lkml]   [2016]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 9/9] x86/xsaves: Re-enable XSAVES
On Tue, Mar 01, 2016 at 04:45:41PM -0800, Dave Hansen wrote:
> >>> + WARN_ONCE((xfeatures_mask & XFEATURE_MASK_SUPERVISOR),
> >>> + "x86/fpu: XSAVES supervisor states are not yet implemented.\n");
> >>> +
> >>> cr4_set_bits(X86_CR4_OSXSAVE);
> >>> xsetbv(XCR_XFEATURE_ENABLED_MASK, xfeatures_mask);
> >>> }
> >>
> >> Let's also do a:
> >>
> >> xfeatures_mask &= ~XFEATURE_MASK_SUPERVISOR;
> >>
> >> Otherwise, we have a broken system at the moment.
> >>
> > Currently, if anyone sets any supervisor state in xfeatures_mask, the
> > kernel prints out the warning then goes into a protection fault.
> > That is a very strong indication to the user. Do we want to mute it?
>
> By "goes into a protection fault", do you mean that it doesn't boot?
>
> I'd just rather we put the kernel in a known-safe configuration (masking
> supervisor state out of xfeatures_mask) rather than rely on the general
> protection fault continuing to be generated by whatever is generating it.
>
Ok.

Yu-cheng

\
 
 \ /
  Last update: 2016-03-02 02:21    [W:0.036 / U:1.960 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site