lkml.org 
[lkml]   [2016]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 150/342] Bluetooth: 6lowpan: Fix kernel NULL pointer dereferences
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Glenn Ruben Bakke <glenn.ruben.bakke@nordicsemi.no>

    commit 4c58f3282e3de43d34f8955f8eca676294380bf9 upstream.

    The fixes provided in this patch assigns a valid net_device structure to
    skb before dispatching it for further processing.

    Scenario #1:
    ============

    Bluetooth 6lowpan receives an uncompressed IPv6 header, and dispatches it
    to netif. The following error occurs:

    Null pointer dereference error #1 crash log:

    [ 845.854013] BUG: unable to handle kernel NULL pointer dereference at
    0000000000000048
    [ 845.855785] IP: [<ffffffff816e3d36>] enqueue_to_backlog+0x56/0x240
    ...
    [ 845.909459] Call Trace:
    [ 845.911678] [<ffffffff816e3f64>] netif_rx_internal+0x44/0xf0

    The first modification fixes the NULL pointer dereference error by
    assigning dev to the local_skb in order to set a valid net_device before
    processing the skb by netif_rx_ni().

    Scenario #2:
    ============

    Bluetooth 6lowpan receives an UDP compressed message which needs further
    decompression by nhc_udp. The following error occurs:

    Null pointer dereference error #2 crash log:

    [ 63.295149] BUG: unable to handle kernel NULL pointer dereference at
    0000000000000840
    [ 63.295931] IP: [<ffffffffc0559540>] udp_uncompress+0x320/0x626
    [nhc_udp]

    The second modification fixes the NULL pointer dereference error by
    assigning dev to the local_skb in the case of a udp compressed packet.
    The 6lowpan udp_uncompress function expects that the net_device is set in
    the skb when checking lltype.

    Signed-off-by: Glenn Ruben Bakke <glenn.ruben.bakke@nordicsemi.no>
    Signed-off-by: Lukasz Duda <lukasz.duda@nordicsemi.no>
    Acked-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
    Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    net/bluetooth/6lowpan.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/net/bluetooth/6lowpan.c
    +++ b/net/bluetooth/6lowpan.c
    @@ -317,6 +317,7 @@ static int recv_pkt(struct sk_buff *skb,

    local_skb->protocol = htons(ETH_P_IPV6);
    local_skb->pkt_type = PACKET_HOST;
    + local_skb->dev = dev;

    skb_set_transport_header(local_skb, sizeof(struct ipv6hdr));

    @@ -335,6 +336,8 @@ static int recv_pkt(struct sk_buff *skb,
    if (!local_skb)
    goto drop;

    + local_skb->dev = dev;
    +
    ret = iphc_decompress(local_skb, dev, chan);
    if (ret < 0) {
    kfree_skb(local_skb);
    @@ -343,7 +346,6 @@ static int recv_pkt(struct sk_buff *skb,

    local_skb->protocol = htons(ETH_P_IPV6);
    local_skb->pkt_type = PACKET_HOST;
    - local_skb->dev = dev;

    if (give_skb_to_upper(local_skb, dev)
    != NET_RX_SUCCESS) {
    \
     
     \ /
      Last update: 2016-03-02 02:21    [W:4.069 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site