Messages in this thread | | | From | Alexander Kuleshov <> | Date | Mon, 8 Feb 2016 23:21:54 +0600 | Subject | Re: [PATCH] x86/setup: refactor initrd reservation |
| |
On Mon, Feb 8, 2016 at 9:56 PM, Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Fri, Feb 5, 2016 at 7:38 PM, Alexander Kuleshov > <kuleshovmail@gmail.com> wrote: >> The check and definitions related to ramdisk are similar in the >> early_reserve_initrd() and reserve_initrd(). So we can get rid of >> early_reserve_initrd() and and use late or early algorithm for >> initrd reservation depends on reserve_initrd() parameter value. > > Perhaps: "Squash {early_,}reserve_initrd() to one function" would be > better for Subject line since it describes what you are doing here > (Answering question "What kind of refactor?"). > > Also if you have more argument (like .text size before and after) I > suppose it would have been passed faster. >
Hello Andy, thanks for your suggestions. Will update it in second revision.
| |