lkml.org 
[lkml]   [2016]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/6] net: thunderx: bgx: Add log message when setting mac address
On 08.02.16 16:30:37, Sergei Shtylyov wrote:
> >@@ -897,10 +898,13 @@ static int acpi_get_mac_address(struct acpi_device *adev, u8 *dst)
> > goto out;
> >
> > if (!is_valid_ether_addr(mac)) {
> >+ dev_warn(dev, "MAC address invalid: %pM\n", mac);
>
> dev_er(), maybe?

Since the driver may continue, my choice was a warning only.

-Robert

>
> > ret = -EINVAL;
> > goto out;
> > }
> >
> >+ dev_info(dev, "MAC address set to: %pM\n", mac);
> >+
> > memcpy(dst, mac, ETH_ALEN);
> > out:
> > return ret;
> [...]

\
 
 \ /
  Last update: 2016-02-08 15:21    [W:1.094 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site