lkml.org 
[lkml]   [2016]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V3 09/13] cpufreq: governor: Move common sysfs tunables to cpufreq_governor.c
    On 08-02-16, 13:58, Rafael J. Wysocki wrote:
    > My most fundamental concern here is that attributes that don't apply
    > to a particular governor should not appear in sysfs at all when that
    > governor is in use (instead of appearing and always returning -EINVAL

    s/is in use/is not in use/ ??

    > which is sort of silly).

    But who said that I have made them available always ? Sorry, I didn't
    understood your input.

    I have just moved the show/store callbacks and the struct
    governor_attr definition to cpufreq_governor.c. And sysfs files are
    created only for the ones that are valid for a governor.

    > That doesn't mean the common code cannot access them, though. They
    > still can be present in the data structure, but it may be a good idea
    > to set them to special values clearly meaning "invalid" then.

    Or are you saying that we should move all the tunables to dbs_data ?

    --
    viresh

    \
     
     \ /
      Last update: 2016-02-08 14:21    [W:4.025 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site