Messages in this thread | | | Subject | Re: [PATCH v2 0/4] powerpc/ps3: gelic_udbg: drop local versions of network data structs | From | Michael Ellerman <> | Date | Tue, 09 Feb 2016 13:54:12 +1100 |
| |
On Mon, 2016-02-08 at 22:27 +0000, Luis Henriques wrote:
> Several network-related data structures are defined in gelic_udbg. > These could be easily dropped and the standard ones defined in network > headers could be used instead. > > The 4 patches that follow replace ethernet, vlan, ip and udp > structures in gelic_udbg. Note that this has been compile-tested > only. > > Changes since v1: > Include changes suggested by Joe Perches, namely the usage of > eth_broadcast_addr(), ETH_ALEN, ETH_P_8021Q and ETH_P_IP. > > Luis Henriques (4): > powerpc/ps3: gelic_udbg: use struct ethhdr from <linux/if_ether.h> > powerpc/ps3: gelic_udbg: use struct vlan_hdr from <linux/if_vlan.h> > powerpc/ps3: gelic_udbg: use struct iphdr from <linux/ip.h> > powerpc/ps3: gelic_udbg: use struct udphdr from <linux/udp.h>
These look good. But I don't have a setup to test them, does anyone?
I'll merge them and hopefully someone can test them at some point.
cheers
| |