lkml.org 
[lkml]   [2016]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] gpio: davinci: Add the missing of-node pointer in the irq_domain_add_legacy function call
From
Date


On Thursday 28 January 2016 07:48 PM, Grygorii Strashko wrote:
> On 01/28/2016 03:38 PM, Keerthy wrote:
>> Currently the first parameter of irq_domain_add_legacy is NULL.
>> irq_find_host function returns NULL when we do not populate the of_node
>> and hence irq_of_parse_and_map call fails whenever we want to request a
>> gpio irq. This fixes the request_irq failures for gpio interrupts.
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>
> Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>

A gentle ping on this patch. Thanks Grygorii for the review.

>
>> ---
>> drivers/gpio/gpio-davinci.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
>> index ec58f42..c889f31 100644
>> --- a/drivers/gpio/gpio-davinci.c
>> +++ b/drivers/gpio/gpio-davinci.c
>> @@ -511,7 +511,7 @@ static int davinci_gpio_irq_setup(struct
>> platform_device *pdev)
>> return irq;
>> }
>>
>> - irq_domain = irq_domain_add_legacy(NULL, ngpio, irq, 0,
>> + irq_domain = irq_domain_add_legacy(dev->of_node, ngpio, irq, 0,
>> &davinci_gpio_irq_ops,
>> chips);
>> if (!irq_domain) {
>>
>
>

\
 
 \ /
  Last update: 2016-02-08 11:21    [W:0.051 / U:0.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site